-
Notifications
You must be signed in to change notification settings - Fork 13
Move IaC files to a specified folder #144
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Elbaz <[email protected]>
Signed-off-by: Elbaz <[email protected]>
Signed-off-by: Elbaz <[email protected]>
@@ -44,7 +44,9 @@ jobs: | |||
aws-region: ${{ secrets.AWS_REGION }} | |||
|
|||
- name: Initialize Terraform | |||
run: terraform init | |||
run: | | |||
cd iac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that the right way to do it?
if so I'll split it to another step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW it might actually be better to use a working-directory
parameter, like so:
cd iac | |
run: terraform init | |
working-directory: "./iac" |
I've aired my opinion on this on the attached issue. I propose we close this. |
@Yantrio we can rename that folder, but let's push this one forward as it would help reading that project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is hard. I personally would have called it infra
to avoid ambiguity, but tbh that's not really that important. Keeping the root tidy is the main thing of this PR and I fully agree with it. It doesn't break anything so I'm all in favour (although my approval carries no weight in pr merge).
Move all the IaC files from the project root to a sub folder
Fix #118